Add an option to ignore (block) a user when reporting their events #8471

turt2live · 2022-05-02T20:29:14Z

This is primarily useful if the content being reported really doesn't belong on your screen, and the room moderators are slow to react.

Ideally we'd use the word "block" instead of "ignore", but we call it "ignore user" everywhere else. See element-hq/element-meta#301 for further context on the word choice.

This change includes a minor refactor to the styles of labelled toggles (for reusability).

Here's what your changelog entry will look like:

✨ Features

Add an option to ignore (block) a user when reporting their events (#8471).

This is primarily useful if the content being reported really doesn't belong on your screen, and the room moderators are slow to react. Ideally we'd use the word "block" instead of "ignore", but we call it "ignore user" everywhere else. See https://github.com/vector-im/element-web/issues/19590 for further context on the word choice. This change includes a minor refactor to the styles of labelled toggles (for reusability).

sonarcloud · 2022-05-02T20:33:20Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
27.5% Duplication

t3chguy

LGTM otherwise

src/components/views/elements/LabelledToggleSwitch.tsx

t3chguy · 2022-05-02T22:12:15Z

src/components/views/dialogs/ReportEventDialog.tsx

@@ -42,6 +43,7 @@ interface IState {
    err?: string;
    // If we know it, the nature of the abuse, as specified by MSC3215.
    nature?: ExtendedNature;
+    ignoreUserToo: boolean; // if true, user will be ignored/blocked on submit


not sure how I feel about the too - ignoreUser should be fine, no?

it just didn't feel right to not acknowledge what the flag was doing. Given the context of the dialog, "ignore user" could mean "instead", "in addition to", or "don't file report". If we used the word "block" throughout the application instead, it'd be more than fine to leave it at blockUser.

janogarcia

@turt2live Toggles, in general, should be used for actions that take place immediately upon acting on them.

Thus, for this case (enabled on form submission), I'd suggest changing it to a checkbox with supporting text as in the mockup below.

turt2live · 2022-05-11T18:33:18Z

sounds good @janogarcia - should we also add a backlog item to use the same design for areas we already use a toggle switch? (mostly widget permissions stuff)

janogarcia · 2022-05-12T06:38:49Z

This will eventually be addressed as part of the the design systems improvements I'm working on, along with other changes. Already on my list but feel free to file an issue for it.

turt2live · 2022-05-12T21:24:49Z

@janogarcia new look:

let me know if further changes need to be made.

janogarcia · 2022-05-18T09:03:56Z

@turt2live There's no Netlify build available this time so, based on your screenshot:

Use $primary-content color for the checkbox label (Ignore user)
Use $secondary-content color for the checkbox supporting text and the modal body text (Reporting this message will send its…).

There's a lot more stuff that we could improve in this modal (copy, visual design), and modals in general, but I'm trying to keep the scope reasonable, as upcoming redesigns will address that.

janogarcia

So, there's a 99.9% probability that I'll forget to send my PR comments via the dedicated form:

Please refer to my previous comment
#8471 (comment)

t3chguy · 2022-05-18T09:07:56Z

@janogarcia

I can see the Netlify build from the last change 6 days ago

janogarcia · 2022-05-18T09:16:07Z

@t3chguy Ouch, thanks! I always check the Merge state section on the bottom and look for the Netlify link in the PR description. Could it be that the bot that adds the link to the description stopped working?

janogarcia · 2022-05-18T09:21:36Z

@t3chguy That said, I can't seem to find the deployment status on your second screenshot anywhere here.

t3chguy · 2022-05-18T09:23:29Z

Could it be that the bot that adds the link to the description stopped working?

We got rid of this and stated in the Element Web rooms, it was causing issues with editing PR descriptions due to overwriting them

t3chguy · 2022-05-18T09:25:39Z

@janogarcia do you not see this section at the bottom?

janogarcia · 2022-05-18T09:29:59Z

The deployment section seems to be missing on my end:

t3chguy · 2022-05-18T10:59:51Z

@janogarcia strange, can't find any github documentation on whether this section needs permission to show, the View deployment in the PR timeline should be accessible though, I can see it even in incognito

turt2live · 2022-05-18T13:17:30Z

@turt2live There's no Netlify build available this time so, based on your screenshot:

Use $primary-content color for the checkbox label (Ignore user)

Use $secondary-content color for the checkbox supporting text and the modal body text (Reporting this message will send its…).

There's a lot more stuff that we could improve in this modal (copy, visual design), and modals in general, but I'm trying to keep the scope reasonable, as upcoming redesigns will address that.

@janogarcia I can do this, however it'd be the only dialog in the app which ends up with this treatment. Can we keep it consistent for now and fix dialogs in a future PR? Alternatively, could blindly give all dialogs this treatment, though can't guarantee we have bandwidth to fix inconsistencies.

janogarcia · 2022-05-18T16:02:41Z

@turt2live Makes sense. Let's keep it consistently bad for now (better to have one rather than two suboptimal implementations 🙃). But I promise to come back to this at some point and end with all the awful debt once and for all. 🪄✨👹

janogarcia · 2022-05-18T16:07:35Z

the View deployment in the PR timeline should be accessible though, I can see it even in incognito

@t3chguy Yeah, that even remains visible.

turt2live · 2022-05-18T16:14:18Z

@janogarcia if I can get your review changed to an approval as a formality, it would be appreciated :)

will see what I can do to de-risk maintenance of dialogs outside of this issue (to make them consistently better instead of consistently bad)

janogarcia

@turt2live I re-requested a review for myself. Is that how it's supposed to work?

turt2live · 2022-05-18T16:18:44Z

Should be able to go to the Files Changed tab -> Review Changes dropdown -> Approve radio button -> Submit

(doesn't necessarily require a review request, but good to have one)

turt2live · 2022-05-18T16:19:28Z

oh, you did that. Ignore me - thanks!

janogarcia · 2022-05-18T16:22:40Z

Awesome. Thanks for the tip!

@novocaine

* Builds Windows 32-bit builds once more! ([\element-hq#369](element-hq#369)). Fixes element-hq/element-web#13175. * Option to disable hardware acceleration ([\element-hq#365](element-hq#365)). Fixes element-hq/element-web#13648. Contributed by @novocaine. * Make Lao translation available ([\#22358](element-hq/element-web#22358)). Fixes element-hq/element-web#22327. * Option to disable hardware acceleration on Element Desktop ([\#22295](element-hq/element-web#22295)). Contributed by @novocaine. * Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\#7790](matrix-org/matrix-react-sdk#7790)). Contributed by @johannes-krude. * Live location sharing - open location in OpenStreetMap ([\#8695](matrix-org/matrix-react-sdk#8695)). Contributed by @kerryarchibald. * Show a dialog when Jitsi encounters an error ([\#8701](matrix-org/matrix-react-sdk#8701)). Fixes element-hq/element-web#22284. * Add support for setting the `avatar_url` of widgets by integration managers. ([\#8550](matrix-org/matrix-react-sdk#8550)). Contributed by @Fox32. * Add an option to ignore (block) a user when reporting their events ([\#8471](matrix-org/matrix-react-sdk#8471)). * Add the option to disable hardware acceleration ([\#8655](matrix-org/matrix-react-sdk#8655)). Contributed by @novocaine. * Slightly better presentation of read receipts to screen reader users ([\#8662](matrix-org/matrix-react-sdk#8662)). Fixes element-hq/element-web#22293. Contributed by @pvagner. * Add jump to related event context menu item ([\#6775](matrix-org/matrix-react-sdk#6775)). Fixes element-hq/element-web#19883. * Add public room directory hook ([\#8626](matrix-org/matrix-react-sdk#8626)). * Revert back to using libsqlcipher0 for Debian & Ubuntu packages of Desktop ([\element-hq#367](element-hq#367)). Fixes element-hq/element-web#22325. * Stop Jitsi if we time out while connecting to a video room ([\#22301](element-hq/element-web#22301)). Fixes element-hq/element-web#22283. * Remove inline margin from UTD error message inside a reply tile on ThreadView ([\#8708](matrix-org/matrix-react-sdk#8708)). Fixes element-hq/element-web#22376. Contributed by @luixxiul. * Move unread notification dots of the threads list to the expected position ([\#8700](matrix-org/matrix-react-sdk#8700)). Fixes element-hq/element-web#22350. Contributed by @luixxiul. * Prevent overflow of grid items on a bubble with UTD generally ([\#8697](matrix-org/matrix-react-sdk#8697)). Contributed by @luixxiul. * Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\#8704](matrix-org/matrix-react-sdk#8704)). Fixes element-hq/element-web#22365. Contributed by @luixxiul. * Fix - AccessibleButton does not set disabled attribute ([\#8682](matrix-org/matrix-react-sdk#8682)). Contributed by @kerryarchibald. * Fix font not resetting when logging out ([\#8670](matrix-org/matrix-react-sdk#8670)). Fixes element-hq/element-web#17228. * Fix local aliases section of room settings not working for some homeservers (ie ([\#8698](matrix-org/matrix-react-sdk#8698)). Fixes element-hq/element-web#22337. * Align EventTile_line with display name on message bubble ([\#8692](matrix-org/matrix-react-sdk#8692)). Fixes element-hq/element-web#22343. Contributed by @luixxiul. * Convert references to direct chat -> direct message ([\#8694](matrix-org/matrix-react-sdk#8694)). Contributed by @novocaine. * Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\#8687](matrix-org/matrix-react-sdk#8687)). * Make the empty thread panel fill BaseCard ([\#8690](matrix-org/matrix-react-sdk#8690)). Fixes element-hq/element-web#22338. Contributed by @luixxiul. * Fix edge case around composer handling gendered facepalm emoji ([\#8686](matrix-org/matrix-react-sdk#8686)). * Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\#8688](matrix-org/matrix-react-sdk#8688)). Fixes element-hq/element-web#21914. Contributed by @luixxiul. * Apply the same max-width to image tile on the thread timeline as message bubble ([\#8669](matrix-org/matrix-react-sdk#8669)). Fixes element-hq/element-web#22313. Contributed by @luixxiul. * Fix dropdown button size for picture-in-picture CallView ([\#8680](matrix-org/matrix-react-sdk#8680)). Fixes element-hq/element-web#22316. Contributed by @luixxiul. * Live location sharing - fix square border for image-less avatar (PSF-1052) ([\#8679](matrix-org/matrix-react-sdk#8679)). Contributed by @kerryarchibald. * Stop connecting to a video room if the widget messaging disappears ([\#8660](matrix-org/matrix-react-sdk#8660)). * Fix file button and audio player overflowing from message bubble ([\#8666](matrix-org/matrix-react-sdk#8666)). Fixes element-hq/element-web#22308. Contributed by @luixxiul. * Don't show broken composer format bar when selection is whitespace ([\#8673](matrix-org/matrix-react-sdk#8673)). Fixes element-hq/element-web#10788. * Fix media upload http 413 handling ([\#8674](matrix-org/matrix-react-sdk#8674)). * Fix emoji picker for editing thread responses ([\#8671](matrix-org/matrix-react-sdk#8671)). Fixes matrix-org/element-web-rageshakes#13129. * Map attribution while sharing live location is now visible ([\#8621](matrix-org/matrix-react-sdk#8621)). Fixes element-hq/element-web#22236. Contributed by @weeman1337. * Fix info tile overlapping the time stamp on TimelineCard ([\#8639](matrix-org/matrix-react-sdk#8639)). Fixes element-hq/element-web#22256. Contributed by @luixxiul. * Fix position of wide images on IRC / modern layout ([\#8667](matrix-org/matrix-react-sdk#8667)). Fixes element-hq/element-web#22309. Contributed by @luixxiul. * Fix other user's displayName being wrapped on the bubble message layout ([\#8456](matrix-org/matrix-react-sdk#8456)). Fixes element-hq/element-web#22004. Contributed by @luixxiul. * Set spacing declarations to elements in mx_EventTile_mediaLine ([\#8665](matrix-org/matrix-react-sdk#8665)). Fixes element-hq/element-web#22307. Contributed by @luixxiul. * Fix wide image overflowing from the thumbnail container ([\#8663](matrix-org/matrix-react-sdk#8663)). Fixes element-hq/element-web#22303. Contributed by @luixxiul. * Fix styles of "Show all" link button on ReactionsRow ([\#8658](matrix-org/matrix-react-sdk#8658)). Fixes element-hq/element-web#22300. Contributed by @luixxiul. * Automatically log in after registration ([\#8654](matrix-org/matrix-react-sdk#8654)). Fixes element-hq/element-web#19305. Contributed by @justjanne. * Fix offline status in window title not working reliably ([\#8656](matrix-org/matrix-react-sdk#8656)). * Align input area with event body's first letter in a thread on IRC/modern layout ([\#8636](matrix-org/matrix-react-sdk#8636)). Fixes element-hq/element-web#22252. Contributed by @luixxiul. * Fix crash on null idp for SSO buttons ([\#8650](matrix-org/matrix-react-sdk#8650)). Contributed by @hughns. * Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\#8648](matrix-org/matrix-react-sdk#8648)). Fixes element-hq/element-web#22279. * Show notifications even when Element is focused ([\#8590](matrix-org/matrix-react-sdk#8590)). Contributed by @sumnerevans. * Remove padding from the buttons on edit message composer of a event tile on a thread ([\#8632](matrix-org/matrix-react-sdk#8632)). Contributed by @luixxiul. * ensure metaspace changes correctly notify listeners ([\#8611](matrix-org/matrix-react-sdk#8611)). Fixes element-hq/element-web#21006. Contributed by @justjanne. * Hide image banner on stickers, they have a tooltip already ([\#8641](matrix-org/matrix-react-sdk#8641)). Fixes element-hq/element-web#22244. * Adjust EditMessageComposer style declarations ([\#8631](matrix-org/matrix-react-sdk#8631)). Fixes element-hq/element-web#22231. Contributed by @luixxiul.

@novocaine

* Make Lao translation available ([\element-hq#22358](element-hq#22358)). Fixes element-hq#22327. * Option to disable hardware acceleration on Element Desktop ([\element-hq#22295](element-hq#22295)). Contributed by @novocaine. * Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\element-hq#7790](matrix-org/matrix-react-sdk#7790)). Contributed by @johannes-krude. * Live location sharing - open location in OpenStreetMap ([\element-hq#8695](matrix-org/matrix-react-sdk#8695)). Contributed by @kerryarchibald. * Show a dialog when Jitsi encounters an error ([\element-hq#8701](matrix-org/matrix-react-sdk#8701)). Fixes element-hq#22284. * Add support for setting the `avatar_url` of widgets by integration managers. ([\element-hq#8550](matrix-org/matrix-react-sdk#8550)). Contributed by @Fox32. * Add an option to ignore (block) a user when reporting their events ([\element-hq#8471](matrix-org/matrix-react-sdk#8471)). * Add the option to disable hardware acceleration ([\element-hq#8655](matrix-org/matrix-react-sdk#8655)). Contributed by @novocaine. * Slightly better presentation of read receipts to screen reader users ([\element-hq#8662](matrix-org/matrix-react-sdk#8662)). Fixes element-hq#22293. Contributed by @pvagner. * Add jump to related event context menu item ([\element-hq#6775](matrix-org/matrix-react-sdk#6775)). Fixes element-hq#19883. * Add public room directory hook ([\element-hq#8626](matrix-org/matrix-react-sdk#8626)). * Stop Jitsi if we time out while connecting to a video room ([\element-hq#22301](element-hq#22301)). Fixes element-hq#22283. * Remove inline margin from UTD error message inside a reply tile on ThreadView ([\element-hq#8708](matrix-org/matrix-react-sdk#8708)). Fixes element-hq#22376. Contributed by @luixxiul. * Move unread notification dots of the threads list to the expected position ([\element-hq#8700](matrix-org/matrix-react-sdk#8700)). Fixes element-hq#22350. Contributed by @luixxiul. * Prevent overflow of grid items on a bubble with UTD generally ([\element-hq#8697](matrix-org/matrix-react-sdk#8697)). Contributed by @luixxiul. * Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\element-hq#8704](matrix-org/matrix-react-sdk#8704)). Fixes element-hq#22365. Contributed by @luixxiul. * Fix - AccessibleButton does not set disabled attribute ([\element-hq#8682](matrix-org/matrix-react-sdk#8682)). Contributed by @kerryarchibald. * Fix font not resetting when logging out ([\element-hq#8670](matrix-org/matrix-react-sdk#8670)). Fixes element-hq#17228. * Fix local aliases section of room settings not working for some homeservers (ie ([\element-hq#8698](matrix-org/matrix-react-sdk#8698)). Fixes element-hq#22337. * Align EventTile_line with display name on message bubble ([\element-hq#8692](matrix-org/matrix-react-sdk#8692)). Fixes element-hq#22343. Contributed by @luixxiul. * Convert references to direct chat -> direct message ([\element-hq#8694](matrix-org/matrix-react-sdk#8694)). Contributed by @novocaine. * Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\element-hq#8687](matrix-org/matrix-react-sdk#8687)). * Make the empty thread panel fill BaseCard ([\element-hq#8690](matrix-org/matrix-react-sdk#8690)). Fixes element-hq#22338. Contributed by @luixxiul. * Fix edge case around composer handling gendered facepalm emoji ([\element-hq#8686](matrix-org/matrix-react-sdk#8686)). * Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\element-hq#8688](matrix-org/matrix-react-sdk#8688)). Fixes element-hq#21914. Contributed by @luixxiul. * Apply the same max-width to image tile on the thread timeline as message bubble ([\element-hq#8669](matrix-org/matrix-react-sdk#8669)). Fixes element-hq#22313. Contributed by @luixxiul. * Fix dropdown button size for picture-in-picture CallView ([\element-hq#8680](matrix-org/matrix-react-sdk#8680)). Fixes element-hq#22316. Contributed by @luixxiul. * Live location sharing - fix square border for image-less avatar (PSF-1052) ([\element-hq#8679](matrix-org/matrix-react-sdk#8679)). Contributed by @kerryarchibald. * Stop connecting to a video room if the widget messaging disappears ([\element-hq#8660](matrix-org/matrix-react-sdk#8660)). * Fix file button and audio player overflowing from message bubble ([\element-hq#8666](matrix-org/matrix-react-sdk#8666)). Fixes element-hq#22308. Contributed by @luixxiul. * Don't show broken composer format bar when selection is whitespace ([\element-hq#8673](matrix-org/matrix-react-sdk#8673)). Fixes element-hq#10788. * Fix media upload http 413 handling ([\element-hq#8674](matrix-org/matrix-react-sdk#8674)). * Fix emoji picker for editing thread responses ([\element-hq#8671](matrix-org/matrix-react-sdk#8671)). Fixes matrix-org/element-web-rageshakes#13129. * Map attribution while sharing live location is now visible ([\element-hq#8621](matrix-org/matrix-react-sdk#8621)). Fixes element-hq#22236. Contributed by @weeman1337. * Fix info tile overlapping the time stamp on TimelineCard ([\element-hq#8639](matrix-org/matrix-react-sdk#8639)). Fixes element-hq#22256. Contributed by @luixxiul. * Fix position of wide images on IRC / modern layout ([\element-hq#8667](matrix-org/matrix-react-sdk#8667)). Fixes element-hq#22309. Contributed by @luixxiul. * Fix other user's displayName being wrapped on the bubble message layout ([\element-hq#8456](matrix-org/matrix-react-sdk#8456)). Fixes element-hq#22004. Contributed by @luixxiul. * Set spacing declarations to elements in mx_EventTile_mediaLine ([\element-hq#8665](matrix-org/matrix-react-sdk#8665)). Fixes element-hq#22307. Contributed by @luixxiul. * Fix wide image overflowing from the thumbnail container ([\element-hq#8663](matrix-org/matrix-react-sdk#8663)). Fixes element-hq#22303. Contributed by @luixxiul. * Fix styles of "Show all" link button on ReactionsRow ([\element-hq#8658](matrix-org/matrix-react-sdk#8658)). Fixes element-hq#22300. Contributed by @luixxiul. * Automatically log in after registration ([\element-hq#8654](matrix-org/matrix-react-sdk#8654)). Fixes element-hq#19305. Contributed by @justjanne. * Fix offline status in window title not working reliably ([\element-hq#8656](matrix-org/matrix-react-sdk#8656)). * Align input area with event body's first letter in a thread on IRC/modern layout ([\element-hq#8636](matrix-org/matrix-react-sdk#8636)). Fixes element-hq#22252. Contributed by @luixxiul. * Fix crash on null idp for SSO buttons ([\element-hq#8650](matrix-org/matrix-react-sdk#8650)). Contributed by @hughns. * Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\element-hq#8648](matrix-org/matrix-react-sdk#8648)). Fixes element-hq#22279. * Show notifications even when Element is focused ([\element-hq#8590](matrix-org/matrix-react-sdk#8590)). Contributed by @sumnerevans. * Remove padding from the buttons on edit message composer of a event tile on a thread ([\element-hq#8632](matrix-org/matrix-react-sdk#8632)). Contributed by @luixxiul. * ensure metaspace changes correctly notify listeners ([\element-hq#8611](matrix-org/matrix-react-sdk#8611)). Fixes element-hq#21006. Contributed by @justjanne. * Hide image banner on stickers, they have a tooltip already ([\element-hq#8641](matrix-org/matrix-react-sdk#8641)). Fixes element-hq#22244. * Adjust EditMessageComposer style declarations ([\element-hq#8631](matrix-org/matrix-react-sdk#8631)). Fixes element-hq#22231. Contributed by @luixxiul.

@johannes-krude

* Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\matrix-org#7790](matrix-org#7790)). Contributed by @johannes-krude. * Live location sharing - open location in OpenStreetMap ([\matrix-org#8695](matrix-org#8695)). Contributed by @kerryarchibald. * Show a dialog when Jitsi encounters an error ([\matrix-org#8701](matrix-org#8701)). Fixes element-hq/element-web#22284. * Add support for setting the `avatar_url` of widgets by integration managers. ([\matrix-org#8550](matrix-org#8550)). Contributed by @Fox32. * Add an option to ignore (block) a user when reporting their events ([\matrix-org#8471](matrix-org#8471)). * Add the option to disable hardware acceleration ([\matrix-org#8655](matrix-org#8655)). Contributed by @novocaine. * Slightly better presentation of read receipts to screen reader users ([\matrix-org#8662](matrix-org#8662)). Fixes element-hq/element-web#22293. Contributed by @pvagner. * Add jump to related event context menu item ([\matrix-org#6775](matrix-org#6775)). Fixes element-hq/element-web#19883. * Add public room directory hook ([\matrix-org#8626](matrix-org#8626)). * Remove inline margin from UTD error message inside a reply tile on ThreadView ([\matrix-org#8708](matrix-org#8708)). Fixes element-hq/element-web#22376. Contributed by @luixxiul. * Move unread notification dots of the threads list to the expected position ([\matrix-org#8700](matrix-org#8700)). Fixes element-hq/element-web#22350. Contributed by @luixxiul. * Prevent overflow of grid items on a bubble with UTD generally ([\matrix-org#8697](matrix-org#8697)). Contributed by @luixxiul. * Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\matrix-org#8704](matrix-org#8704)). Fixes element-hq/element-web#22365. Contributed by @luixxiul. * Fix - AccessibleButton does not set disabled attribute ([\matrix-org#8682](matrix-org#8682)). Contributed by @kerryarchibald. * Fix font not resetting when logging out ([\matrix-org#8670](matrix-org#8670)). Fixes element-hq/element-web#17228. * Fix local aliases section of room settings not working for some homeservers (ie ([\matrix-org#8698](matrix-org#8698)). Fixes element-hq/element-web#22337. * Align EventTile_line with display name on message bubble ([\matrix-org#8692](matrix-org#8692)). Fixes element-hq/element-web#22343. Contributed by @luixxiul. * Convert references to direct chat -> direct message ([\matrix-org#8694](matrix-org#8694)). Contributed by @novocaine. * Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\matrix-org#8687](matrix-org#8687)). * Make the empty thread panel fill BaseCard ([\matrix-org#8690](matrix-org#8690)). Fixes element-hq/element-web#22338. Contributed by @luixxiul. * Fix edge case around composer handling gendered facepalm emoji ([\matrix-org#8686](matrix-org#8686)). * Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\matrix-org#8688](matrix-org#8688)). Fixes element-hq/element-web#21914. Contributed by @luixxiul. * Apply the same max-width to image tile on the thread timeline as message bubble ([\matrix-org#8669](matrix-org#8669)). Fixes element-hq/element-web#22313. Contributed by @luixxiul. * Fix dropdown button size for picture-in-picture CallView ([\matrix-org#8680](matrix-org#8680)). Fixes element-hq/element-web#22316. Contributed by @luixxiul. * Live location sharing - fix square border for image-less avatar (PSF-1052) ([\matrix-org#8679](matrix-org#8679)). Contributed by @kerryarchibald. * Stop connecting to a video room if the widget messaging disappears ([\matrix-org#8660](matrix-org#8660)). * Fix file button and audio player overflowing from message bubble ([\matrix-org#8666](matrix-org#8666)). Fixes element-hq/element-web#22308. Contributed by @luixxiul. * Don't show broken composer format bar when selection is whitespace ([\matrix-org#8673](matrix-org#8673)). Fixes element-hq/element-web#10788. * Fix media upload http 413 handling ([\matrix-org#8674](matrix-org#8674)). * Fix emoji picker for editing thread responses ([\matrix-org#8671](matrix-org#8671)). Fixes matrix-org/element-web-rageshakes#13129. * Map attribution while sharing live location is now visible ([\matrix-org#8621](matrix-org#8621)). Fixes element-hq/element-web#22236. Contributed by @weeman1337. * Fix info tile overlapping the time stamp on TimelineCard ([\matrix-org#8639](matrix-org#8639)). Fixes element-hq/element-web#22256. Contributed by @luixxiul. * Fix position of wide images on IRC / modern layout ([\matrix-org#8667](matrix-org#8667)). Fixes element-hq/element-web#22309. Contributed by @luixxiul. * Fix other user's displayName being wrapped on the bubble message layout ([\matrix-org#8456](matrix-org#8456)). Fixes element-hq/element-web#22004. Contributed by @luixxiul. * Set spacing declarations to elements in mx_EventTile_mediaLine ([\matrix-org#8665](matrix-org#8665)). Fixes element-hq/element-web#22307. Contributed by @luixxiul. * Fix wide image overflowing from the thumbnail container ([\matrix-org#8663](matrix-org#8663)). Fixes element-hq/element-web#22303. Contributed by @luixxiul. * Fix styles of "Show all" link button on ReactionsRow ([\matrix-org#8658](matrix-org#8658)). Fixes element-hq/element-web#22300. Contributed by @luixxiul. * Automatically log in after registration ([\matrix-org#8654](matrix-org#8654)). Fixes element-hq/element-web#19305. Contributed by @justjanne. * Fix offline status in window title not working reliably ([\matrix-org#8656](matrix-org#8656)). * Align input area with event body's first letter in a thread on IRC/modern layout ([\matrix-org#8636](matrix-org#8636)). Fixes element-hq/element-web#22252. Contributed by @luixxiul. * Fix crash on null idp for SSO buttons ([\matrix-org#8650](matrix-org#8650)). Contributed by @hughns. * Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\matrix-org#8648](matrix-org#8648)). Fixes element-hq/element-web#22279. * Show notifications even when Element is focused ([\matrix-org#8590](matrix-org#8590)). Contributed by @sumnerevans. * Remove padding from the buttons on edit message composer of a event tile on a thread ([\matrix-org#8632](matrix-org#8632)). Contributed by @luixxiul. * ensure metaspace changes correctly notify listeners ([\matrix-org#8611](matrix-org#8611)). Fixes element-hq/element-web#21006. Contributed by @justjanne. * Hide image banner on stickers, they have a tooltip already ([\matrix-org#8641](matrix-org#8641)). Fixes element-hq/element-web#22244. * Adjust EditMessageComposer style declarations ([\matrix-org#8631](matrix-org#8631)). Fixes element-hq/element-web#22231. Contributed by @luixxiul.

@novocaine

* Make Lao translation available ([\#22358](element-hq/element-web#22358)). Fixes #22327. * Option to disable hardware acceleration on Element Desktop ([\#22295](element-hq/element-web#22295)). Contributed by @novocaine. * Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\#7790](matrix-org/matrix-react-sdk#7790)). Contributed by @johannes-krude. * Live location sharing - open location in OpenStreetMap ([\#8695](matrix-org/matrix-react-sdk#8695)). Contributed by @kerryarchibald. * Show a dialog when Jitsi encounters an error ([\#8701](matrix-org/matrix-react-sdk#8701)). Fixes #22284. * Add support for setting the `avatar_url` of widgets by integration managers. ([\#8550](matrix-org/matrix-react-sdk#8550)). Contributed by @Fox32. * Add an option to ignore (block) a user when reporting their events ([\#8471](matrix-org/matrix-react-sdk#8471)). * Add the option to disable hardware acceleration ([\#8655](matrix-org/matrix-react-sdk#8655)). Contributed by @novocaine. * Slightly better presentation of read receipts to screen reader users ([\#8662](matrix-org/matrix-react-sdk#8662)). Fixes #22293. Contributed by @pvagner. * Add jump to related event context menu item ([\#6775](matrix-org/matrix-react-sdk#6775)). Fixes #19883. * Add public room directory hook ([\#8626](matrix-org/matrix-react-sdk#8626)). * Stop Jitsi if we time out while connecting to a video room ([\#22301](element-hq/element-web#22301)). Fixes #22283. * Remove inline margin from UTD error message inside a reply tile on ThreadView ([\#8708](matrix-org/matrix-react-sdk#8708)). Fixes #22376. Contributed by @luixxiul. * Move unread notification dots of the threads list to the expected position ([\#8700](matrix-org/matrix-react-sdk#8700)). Fixes #22350. Contributed by @luixxiul. * Prevent overflow of grid items on a bubble with UTD generally ([\#8697](matrix-org/matrix-react-sdk#8697)). Contributed by @luixxiul. * Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\#8704](matrix-org/matrix-react-sdk#8704)). Fixes #22365. Contributed by @luixxiul. * Fix - AccessibleButton does not set disabled attribute ([\#8682](matrix-org/matrix-react-sdk#8682)). Contributed by @kerryarchibald. * Fix font not resetting when logging out ([\#8670](matrix-org/matrix-react-sdk#8670)). Fixes #17228. * Fix local aliases section of room settings not working for some homeservers (ie ([\#8698](matrix-org/matrix-react-sdk#8698)). Fixes #22337. * Align EventTile_line with display name on message bubble ([\#8692](matrix-org/matrix-react-sdk#8692)). Fixes #22343. Contributed by @luixxiul. * Convert references to direct chat -> direct message ([\#8694](matrix-org/matrix-react-sdk#8694)). Contributed by @novocaine. * Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\#8687](matrix-org/matrix-react-sdk#8687)). * Make the empty thread panel fill BaseCard ([\#8690](matrix-org/matrix-react-sdk#8690)). Fixes #22338. Contributed by @luixxiul. * Fix edge case around composer handling gendered facepalm emoji ([\#8686](matrix-org/matrix-react-sdk#8686)). * Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\#8688](matrix-org/matrix-react-sdk#8688)). Fixes #21914. Contributed by @luixxiul. * Apply the same max-width to image tile on the thread timeline as message bubble ([\#8669](matrix-org/matrix-react-sdk#8669)). Fixes #22313. Contributed by @luixxiul. * Fix dropdown button size for picture-in-picture CallView ([\#8680](matrix-org/matrix-react-sdk#8680)). Fixes #22316. Contributed by @luixxiul. * Live location sharing - fix square border for image-less avatar (PSF-1052) ([\#8679](matrix-org/matrix-react-sdk#8679)). Contributed by @kerryarchibald. * Stop connecting to a video room if the widget messaging disappears ([\#8660](matrix-org/matrix-react-sdk#8660)). * Fix file button and audio player overflowing from message bubble ([\#8666](matrix-org/matrix-react-sdk#8666)). Fixes #22308. Contributed by @luixxiul. * Don't show broken composer format bar when selection is whitespace ([\#8673](matrix-org/matrix-react-sdk#8673)). Fixes #10788. * Fix media upload http 413 handling ([\#8674](matrix-org/matrix-react-sdk#8674)). * Fix emoji picker for editing thread responses ([\#8671](matrix-org/matrix-react-sdk#8671)). Fixes matrix-org/element-web-rageshakes#13129. * Map attribution while sharing live location is now visible ([\#8621](matrix-org/matrix-react-sdk#8621)). Fixes #22236. Contributed by @weeman1337. * Fix info tile overlapping the time stamp on TimelineCard ([\#8639](matrix-org/matrix-react-sdk#8639)). Fixes #22256. Contributed by @luixxiul. * Fix position of wide images on IRC / modern layout ([\#8667](matrix-org/matrix-react-sdk#8667)). Fixes #22309. Contributed by @luixxiul. * Fix other user's displayName being wrapped on the bubble message layout ([\#8456](matrix-org/matrix-react-sdk#8456)). Fixes #22004. Contributed by @luixxiul. * Set spacing declarations to elements in mx_EventTile_mediaLine ([\#8665](matrix-org/matrix-react-sdk#8665)). Fixes #22307. Contributed by @luixxiul. * Fix wide image overflowing from the thumbnail container ([\#8663](matrix-org/matrix-react-sdk#8663)). Fixes #22303. Contributed by @luixxiul. * Fix styles of "Show all" link button on ReactionsRow ([\#8658](matrix-org/matrix-react-sdk#8658)). Fixes #22300. Contributed by @luixxiul. * Automatically log in after registration ([\#8654](matrix-org/matrix-react-sdk#8654)). Fixes #19305. Contributed by @justjanne. * Fix offline status in window title not working reliably ([\#8656](matrix-org/matrix-react-sdk#8656)). * Align input area with event body's first letter in a thread on IRC/modern layout ([\#8636](matrix-org/matrix-react-sdk#8636)). Fixes #22252. Contributed by @luixxiul. * Fix crash on null idp for SSO buttons ([\#8650](matrix-org/matrix-react-sdk#8650)). Contributed by @hughns. * Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\#8648](matrix-org/matrix-react-sdk#8648)). Fixes #22279. * Show notifications even when Element is focused ([\#8590](matrix-org/matrix-react-sdk#8590)). Contributed by @sumnerevans. * Remove padding from the buttons on edit message composer of a event tile on a thread ([\#8632](matrix-org/matrix-react-sdk#8632)). Contributed by @luixxiul. * ensure metaspace changes correctly notify listeners ([\#8611](matrix-org/matrix-react-sdk#8611)). Fixes #21006. Contributed by @justjanne. * Hide image banner on stickers, they have a tooltip already ([\#8641](matrix-org/matrix-react-sdk#8641)). Fixes #22244. * Adjust EditMessageComposer style declarations ([\#8631](matrix-org/matrix-react-sdk#8631)). Fixes #22231. Contributed by @luixxiul.

turt2live added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label May 2, 2022

turt2live requested a review from a team May 2, 2022 20:29

turt2live requested a review from a team as a code owner May 2, 2022 20:29

github-actions bot temporarily deployed to Netlify May 2, 2022 20:34 Destroyed

Appease the linter

0d86dd4

github-actions bot temporarily deployed to Netlify May 2, 2022 20:46 Destroyed

t3chguy approved these changes May 2, 2022

View reviewed changes

janogarcia suggested changes May 11, 2022

View reviewed changes

turt2live mentioned this pull request May 12, 2022

Update toggles in widget permission dialogs to match design system (when ready) element-hq/element-web#22159

Open

turt2live added 3 commits May 12, 2022 14:24

Merge branch 'develop' into travis/ignore-user-report

ee21ceb

Use a checkbox instead of toggle in the dialog

33c044b

Update classnames handling for toggle switch

640f9c9

turt2live requested review from janogarcia and t3chguy May 12, 2022 21:24

Appease the linter

9243819

github-actions bot deployed to Netlify May 12, 2022 21:37 View deployment

t3chguy approved these changes May 13, 2022

View reviewed changes

janogarcia suggested changes May 18, 2022

View reviewed changes

Merge branch 'develop' into travis/ignore-user-report

14b0525

janogarcia self-requested a review May 18, 2022 16:15

janogarcia approved these changes May 18, 2022

View reviewed changes

turt2live enabled auto-merge (squash) May 18, 2022 16:19

turt2live merged commit e87bda9 into develop May 18, 2022

turt2live deleted the travis/ignore-user-report branch May 18, 2022 16:20

github-actions bot deployed to Netlify May 18, 2022 16:22 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add an option to ignore (block) a user when reporting their events #8471

Add an option to ignore (block) a user when reporting their events #8471

turt2live commented May 2, 2022 •

edited by github-actions bot

Loading

sonarcloud bot commented May 2, 2022

t3chguy left a comment

t3chguy May 2, 2022

turt2live May 2, 2022

janogarcia left a comment •

edited

Loading

turt2live commented May 11, 2022

janogarcia commented May 12, 2022

turt2live commented May 12, 2022

janogarcia commented May 18, 2022

janogarcia left a comment

t3chguy commented May 18, 2022

janogarcia commented May 18, 2022

janogarcia commented May 18, 2022

t3chguy commented May 18, 2022

t3chguy commented May 18, 2022

janogarcia commented May 18, 2022

t3chguy commented May 18, 2022

turt2live commented May 18, 2022

janogarcia commented May 18, 2022

janogarcia commented May 18, 2022

turt2live commented May 18, 2022

janogarcia left a comment

turt2live commented May 18, 2022

turt2live commented May 18, 2022

janogarcia commented May 18, 2022

Add an option to ignore (block) a user when reporting their events #8471

Add an option to ignore (block) a user when reporting their events #8471

Conversation

turt2live commented May 2, 2022 • edited by github-actions bot Loading

✨ Features

sonarcloud bot commented May 2, 2022

t3chguy left a comment

Choose a reason for hiding this comment

t3chguy May 2, 2022

Choose a reason for hiding this comment

turt2live May 2, 2022

Choose a reason for hiding this comment

janogarcia left a comment • edited Loading

Choose a reason for hiding this comment

turt2live commented May 11, 2022

janogarcia commented May 12, 2022

turt2live commented May 12, 2022

janogarcia commented May 18, 2022

janogarcia left a comment

Choose a reason for hiding this comment

t3chguy commented May 18, 2022

janogarcia commented May 18, 2022

janogarcia commented May 18, 2022

t3chguy commented May 18, 2022

t3chguy commented May 18, 2022

janogarcia commented May 18, 2022

t3chguy commented May 18, 2022

turt2live commented May 18, 2022

janogarcia commented May 18, 2022

janogarcia commented May 18, 2022

turt2live commented May 18, 2022

janogarcia left a comment

Choose a reason for hiding this comment

turt2live commented May 18, 2022

turt2live commented May 18, 2022

janogarcia commented May 18, 2022

turt2live commented May 2, 2022 •

edited by github-actions bot

Loading

janogarcia left a comment •

edited

Loading